fix: reject invalid dynamic filter regexes during config loading#1637
Open
immanuwell wants to merge 1 commit into
Open
fix: reject invalid dynamic filter regexes during config loading#1637immanuwell wants to merge 1 commit into
immanuwell wants to merge 1 commit into
Conversation
SuperQ
reviewed
Jun 30, 2026
Signed-off-by: immanuwell <pchpr.00@list.ru>
immanuwell
force-pushed
the
fix-dynamic-filter-regex-validation
branch
from
aca2df4 to
6d6c606
Compare
Contributor
Author
|
@SuperQ addressed your suggestions, PTAL |
SuperQ
reviewed
Jul 1, 2026
Comment on lines
+252
to
+254
| func (c *DynamicFilter) Regexps() []*regexp.Regexp { | ||
| return c.regexps | ||
| } |
Member
There was a problem hiding this comment.
Minor nit, can we call this Filters for consistency with what it is?
Suggested change
| func (c *DynamicFilter) Regexps() []*regexp.Regexp { | |
| return c.regexps | |
| } | |
| func (c *DynamicFilter) Filters() []*regexp.Regexp { | |
| return c.filters | |
| } |
| Oid string `yaml:"oid"` | ||
| Targets []string `yaml:"targets,omitempty"` | ||
| Values []string `yaml:"values,omitempty"` | ||
| regexps []*regexp.Regexp `yaml:"-"` |
Member
There was a problem hiding this comment.
Suggested change
| regexps []*regexp.Regexp `yaml:"-"` | |
| filters []*regexp.Regexp `yaml:"-"` |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bad dynamic filter regexes are accepted during config load, then can panic later when the scrape path hits
regexp.MustCompile.This makes the exporter reject that config earlier, and keeps the collector off the panic path too. Pretty small fix, but useful.
Repro:
values: ["("]snmp_exporter. Config load is fine on currentmainmissing closing )With this patch, config loading fails early with
invalid dynamic filter value "(".cc @SuperQ